For long task timers removes entries from Dropwizard registry

fixes gh-2924
micrometer-metrics · Dec 22, 2023 · 08573c6 · 08573c6
1 parent e988e3a
commit 08573c6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/...-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistry.java b/...-core/src/main/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistry.java
@@ -71,6 +71,11 @@ public DropwizardMeterRegistry(DropwizardConfig config, MetricRegistry registry,
 
     private void onMeterRemoved(Meter meter) {
         registry.remove(hierarchicalName(meter.getId()));
+        if (meter instanceof LongTaskTimer) {
+            for (Statistic statistic : Statistic.values()) {
+                registry.remove(hierarchicalName(meter.getId().withTag(statistic)));
+            }
+        }
     }
 
     public MetricRegistry getDropwizardRegistry() {

diff --git a/...e/src/test/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistryTest.java b/...e/src/test/java/io/micrometer/core/instrument/dropwizard/DropwizardMeterRegistryTest.java
@@ -111,4 +111,13 @@ void removeShouldWork() {
         assertThat(registry.getDropwizardRegistry().getMeters()).isEmpty();
     }
 
+    @Issue("#2924")
+    @Test
+    void removeShouldWorkForLongTaskTimer() {
+        LongTaskTimer timer = LongTaskTimer.builder("foo").register(registry);
+        assertThat(registry.getDropwizardRegistry().getGauges()).hasSize(3);
+        registry.remove(timer);
+        assertThat(registry.getDropwizardRegistry().getGauges()).isEmpty();
+    }
+
 }