update debug_lua check to match passed in arg type #765
+12
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this was introduced with
SidekiqUniqueJobs::Script::Caller::normalize_argv
The lua scripts check for a value of
"true"
fordebug_lua
butnormalize_arg
changes that to integer 1 that looks to be typed to a string when it gets to the lua script (I don't know lua in any way so this could very well be wrong)also remove unused
toboolean
in lua scriptsI have no idea how to add a test for this.