Test with stable and nightly, build with 1.56 #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The one-month old fix in #515 has already caused problems because a test dependency has bumped its minimum supported Rust version (MSRV). It turns out that Textwrap builds fine on old versions of Rust. It builds all the way back to Rust 1.56 which introduced the 2021 edition we use. To better reflect this, we now _test_ with modern versions of Rust and we build with the old version.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The one-month old fix in #515 has already caused problems because a test dependency has bumped its minimum supported Rust version (MSRV).
It turns out that Textwrap builds fine on old versions of Rust. It builds all the way back to Rust 1.56 which introduced the 2021 edition we use. To better reflect this, we now test with modern versions of Rust and we build with the old version.