Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammatical correction of some comments #699

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Grammatical correction of some comments #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Meziantou.Analyzer/Rules/DoNotUseBlockingCallInAsyncContextAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ internal void AnalyzeInvocation(OperationAnalysisContext context)
var targetMethod = operation.TargetMethod;

// The cache only contains methods with no async equivalent methods.
// This optimize the best-case scenario where code is correctly written according to this analyzer.
// This optimizes the best-case scenario where code is correctly written according to this analyzer.
if (_symbolsWithNoAsyncOverloads.Contains(targetMethod))
return;

Expand Down
4 changes: 2 additions & 2 deletions src/Meziantou.Analyzer/Rules/PreserveParamsOnOverrideAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,8 @@ private static void AnalyzeSymbol(SymbolAnalysisContext context)

var originalParameter = baseSymbol.Parameters[parameter.Ordinal];

// We cannot use parameter.IsParams because on overrided member this is true as it is implicitly inherited.
// Instead we need to check if the syntax contains the keyword explicitly
// We cannot use parameter.IsParams because on overridden member this is true as it is implicitly inherited.
// Instead, we need to check if the syntax contains the keyword explicitly
if (originalParameter.IsParams)
{
if (HasParamsKeyword(parameter, context.CancellationToken))
Expand Down