-
-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/4401 creating langium parser git graph #5664
Feature/4401 creating langium parser git graph #5664
Conversation
…parser_gitGraph
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
I am going to try and make sure the langium file works with the import and then add more tests for coverage and then it should be good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tangential cleanup comments, some of them might be pre-existing code that's not aligned with the current conventions.
Co-authored-by: Sidharth Vinod <github@sidharth.dev>
Co-authored-by: Sidharth Vinod <github@sidharth.dev>
…raph
…parser_gitGraph
…raph
…raph
…raph
…raph
🦋 Changeset detectedLatest commit: 5deaef4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
* develop: (34 commits) Mermaid version v11.0.0 Run release drafter in release branch [autofix.ci] apply automated fixes Updating syntax reference with code showing how to select layout and look. Fix for selecting the correct diagramPadding for flowcharts Fix for turned arrow heads and missing edge sections Basic fix for handdrawn subgraph styling Fix for text alignment issue mermaid-js#5237 Fix for weird line intersection Fix config docs: Update release version docs: Update release version chore: Revert version changes chore: Revert version changes Remove release drafter Add changeset to PR template Remove changesets Update changelog format verify Docs version before publish chore: Remove prePublishOnly ...
@Austin-Fulbright, Thank you for the contribution! |
📑 Summary
This PR changes gitGraphAst.js to use typescript gitGraphAst.ts. There needs to be a lot of refactoring involving the types that each function in gitGraphAst.ts can accept. Since gitGraphAst.ts was originally written in javascript there is a lot of variables that are used to store completely different types in different functions. I am working on fixing some of the failed tests that the commitType is now causing. Other than that this PR request also has a new parser that uses the gitGraph langium parser.
Resolves
📏 Design Decisions
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSION
is used for all new features.develop
branch