Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Cypress tests #5586

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Cleanup Cypress tests #5586

merged 2 commits into from
Jun 20, 2024

Conversation

sidharthv96
Copy link
Member

📑 Summary

Remove unnecessary cy.get('svg') calls.

📏 Design Decisions

It's already checked in the snapshot function.

📋 Tasks

Make sure you

Sorry, something went wrong.

This token is not sensitive, and is required for argos to run in fork PRs.
Copy link

netlify bot commented Jun 20, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 66bc461
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/66742751ea3c14000821ff84
😎 Deploy Preview https://deploy-preview-5586--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 5.73%. Comparing base (fe9fbd8) to head (66bc461).
Report is 4 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5586   +/-   ##
=======================================
  Coverage     5.73%   5.73%           
=======================================
  Files          278     278           
  Lines        41999   41999           
  Branches       490     490           
=======================================
  Hits          2409    2409           
  Misses       39590   39590           
Flag Coverage Δ
unit 5.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

argos-ci bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Jun 20, 2024, 1:03 PM

@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 20, 2024
Merged via the queue into develop with commit a331125 Jun 20, 2024
28 checks passed
@sidharthv96 sidharthv96 deleted the sidv/cleanupCy branch June 20, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant