Skip to content
This repository has been archived by the owner on Apr 10, 2020. It is now read-only.

Fix security vulnerabilities with minimist #17

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Conversation

carolstran
Copy link
Contributor

@carolstran carolstran commented Mar 25, 2020

Relates to #16.

TL;DR

According to GitHub we have two packages in our package-lock.json that need to be addressed:

minimist to version 1.2.2 or later
acorn to version 5.7.4 or later

Commands run

npm audit fix
npm install --save-dev @11ty/eleventy

Lingering issues

πŸ™Ž Acorn wasn't bumped
πŸ™Ž npm audit shows that there's still 1 security vulnerability. When you run npm ls minimist, there's still a version of minimist that hasn't been bumped up:

...
  β”œβ”€β”¬ handlebars@4.7.3
  β”‚ └─┬ optimist@0.6.1
  β”‚   └── minimist@0.0.10
...

πŸ™Ž Even if you solve this (for both minimist and acorn) with resolutions and a preinstall script, you end up with many invalid errors

Help 😩

@carolstran carolstran self-assigned this Mar 25, 2020
Copy link
Contributor

@ksaaskil ksaaskil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@carolstran carolstran changed the title Fix security vulnerabilities with acorn and minimist Fix security vulnerabilities with minimist Mar 25, 2020
@carolstran carolstran marked this pull request as ready for review March 25, 2020 16:20
@carolstran carolstran merged commit 2ac7892 into master Mar 25, 2020
carolstran pushed a commit that referenced this pull request Mar 25, 2020
@carolstran carolstran deleted the securrrity branch March 25, 2020 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants