Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation #9829

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Oct 16, 2023

Summary

@schalkneethling @caugner
cc @hmatrjp @potappo

Problem

still en-us only

Solution

translate japanese for LearnSidebar.ejs

NOTICE

alreday mdn/translated-content#16543 merged.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Oct 16, 2023
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from 9c2ae67 to 8b6aa91 Compare October 16, 2023 15:34
@gurezo gurezo marked this pull request as draft October 16, 2023 15:38
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from 8b6aa91 to c799936 Compare October 16, 2023 15:59
@gurezo gurezo marked this pull request as ready for review October 16, 2023 15:59
@caugner caugner changed the title chore(macros/LearnSidebar): Introduction to client-side frameworks translate chore(macros/LearnSidebar): add Japanese translation Oct 17, 2023
@caugner
Copy link
Contributor

caugner commented Oct 17, 2023

/ping @mdn/yari-content-ja for review

@gurezo
Copy link
Contributor Author

gurezo commented Oct 18, 2023

@caugner

/ping @mdn/yari-content-ja for review

I think you probably haven't been notified of the mention.

@caugner
Copy link
Contributor

caugner commented Oct 27, 2023

@gurezo Unfortunately, I don't speak Japanese. This PR requires a review by @mdn/yari-content-ja before I can merge it.

@gurezo
Copy link
Contributor Author

gurezo commented Oct 27, 2023

@caugner
cc @hmatrjp @potappo
thank you for reply.
Let's ask people involved in the Japanese MDN translation community.

@caugner caugner requested a review from a team as a code owner November 7, 2023 20:05
Copy link
Contributor

@hmatrjp hmatrjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2点疑問があるので、確認させてください。

  1. https://developer.mozilla.org/ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Introduction
    を開くと、左側には、日本語で
    クライアントサイドフレームワークの概要 という表示が出てくる。 ← これが英語のままなので和訳したいというのが、このコミットの意図かと思っていました。
  2. サイド と 側 のずれ

@gurezo
Copy link
Contributor Author

gurezo commented Nov 11, 2023

@hmatrjp

2点疑問があるので、確認させてください。

1. https://developer.mozilla.org/ja/docs/Learn/Tools_and_testing/Client-side_JavaScript_frameworks/Introduction
   を開くと、左側には、日本語で
   クライアントサイドフレームワークの概要 という表示が出てくる。 ← これが英語のままなので和訳したいというのが、このコミットの意図かと思っていました。

はい、その通りです。
赤枠の箇所を日本語にしたいです。
スクリーンショット_2023-10-14_14_00_41

2. サイド と 側 のずれ

こちらはどんな意味でしょうか?

@hmatrjp
Copy link
Contributor

hmatrjp commented Nov 11, 2023

  1. は、 client-side の訳が揺れている、ということです。言葉足らずでした。
    上の行では クライアントサイド
    ページタイトルも クライアントサイド
    なので、合わせた方が良いと思います。

1.の方は私の勘違いでした。日本語になっていた行は、訳されたページタイトルがそのままコピーされているのですね。
(私の方では、このように見えています
image

@gurezo gurezo requested a review from mdn-bot as a code owner November 11, 2023 06:36
@github-actions github-actions bot added dependencies Pull requests that update a dependency file redirects all things related to redirecting flaw-system issues and feature requests related to the flaws system plus work around features related to MDN Plus copy Copy changes to hard-coded texts on the site plus:ai-help labels Nov 11, 2023
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from d7e5080 to 4898b9d Compare November 11, 2023 06:42
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file redirects all things related to redirecting flaw-system issues and feature requests related to the flaws system plus work around features related to MDN Plus labels Nov 11, 2023
@github-actions github-actions bot added flaw-system issues and feature requests related to the flaws system plus work around features related to MDN Plus copy Copy changes to hard-coded texts on the site plus:ai-help labels Nov 11, 2023
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from 6d2f880 to 4898b9d Compare November 11, 2023 09:36
@github-actions github-actions bot removed dependencies Pull requests that update a dependency file redirects all things related to redirecting flaw-system issues and feature requests related to the flaws system plus work around features related to MDN Plus copy Copy changes to hard-coded texts on the site plus:ai-help labels Nov 11, 2023
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from 7e26c3b to 4898b9d Compare November 11, 2023 10:59
@gurezo gurezo marked this pull request as draft November 11, 2023 11:00
@gurezo
Copy link
Contributor Author

gurezo commented Nov 11, 2023

  • GPG 署名問題が解決するまで Draft に戻します
  • Revert to Draft until GPG signature issue is resolved

@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch 6 times, most recently from 3ca9b69 to 680524f Compare November 11, 2023 13:36
@gurezo gurezo marked this pull request as ready for review November 11, 2023 14:17
@gurezo gurezo force-pushed the issues/issue719/Client-side_JavaScript_frameworks/Introduction branch from 680524f to 4898b9d Compare November 11, 2023 14:23
@gurezo
Copy link
Contributor Author

gurezo commented Nov 11, 2023

@caugner

Hi there! i have a question!

my signature commit f54dc03 had pushed.
f54dc03 is verified commit.
but Commit signature check is invalid

I understand that it is created using the tee command in .github/workflows/pr-commit-signatures.yml
I would like to know why GPG-signed commits are rejected.

i had tried that follow commands
after rebase command.

git commit --amend --gpg-sign --no-edit
git push origin issues/issue719/Client-side_JavaScript_frameworks/Introduction -f

verified commit
スクリーンショット 2023-11-11 23 28 29

github gpg setting
スクリーンショット 2023-11-11 23 28 51

@gurezo
Copy link
Contributor Author

gurezo commented Nov 13, 2023

#9829 (comment)

@gurezo
Copy link
Contributor Author

gurezo commented Nov 13, 2023

this PR had closed, for refference to #10019

@gurezo gurezo closed this Nov 13, 2023
Copy link
Contributor

@hmatrjp hmatrjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the retake, with the fix upon with my request on PR #9829.
I approve it.
And also, thank you for your waiting.

(edit)
Sorry for my wrong post. I intended to post this to PR #10019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros needs review from l10n teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants