Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(redirects): remove retiredLocale parameter #11148

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented May 17, 2024

Summary

Problem

We redirect retired locales to en-US with a ?retiredLocale=XX parameter to show a retirement message, but this is no longer useful, as those locales have been retired for more than 1.5 years.

Solution

Remove the retirement message and the retiredLocale parameter.


How did you test this change?

Ran npm i && npm start in /cloud-function and verified that http://localhost:5100/ar/ redirects to http://localhost:5100/en-US/, not http://localhost:5100/en-US/?retiredLocale=ar.

@caugner caugner requested a review from a team as a code owner May 17, 2024 18:44
@github-actions github-actions bot added redirects all things related to redirecting python Pull requests that update Python code labels May 17, 2024
@caugner caugner force-pushed the MP-1112-remove-retiredLocale-param branch from 41b2b3c to a624e6f Compare May 17, 2024 18:47
Copy link
Contributor

@fiji-flo fiji-flo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking context. I appears this removes the feature all together. Could we not just remove the redirect for the old retired locales? But keep the code?

@caugner
Copy link
Contributor Author

caugner commented May 29, 2024

I'm lacking context.

This is part of our SEO effort, reducing the number of duplicate URLs.

Could we not just remove the redirect for the old retired locales? But keep the code?

We could just remove the redirect, but if nothing links/redirects to ?retiredLocale=XX anymore, why should we keep the code around? This makes me think we might want to redirect from foo/bar?retiredLocale=XX to foo/bar.

@caugner caugner requested a review from fiji-flo May 29, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code redirects all things related to redirecting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants