fix(article-footer): reduce margin on small screens #11141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estelle
reviewed
May 17, 2024
caugner
changed the title
caugner
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes margins for the feedback form so the text won’t overflow.
Problem
The feedback form doesn’t fit well on smaller screens (iPhone 15 with 375px viewport).
Solution
Add
@mediacondition for$screen-smto make side margins smaller.Screenshots
Before
After
How did you test this change?
I couldn’t test it because the feedback form is not available when running the project locally. But it tested it in DevTools.