fix(playground): dispatch DOMContentLoaded event manually #10770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argl
approved these changes
Mar 22, 2024
This was referenced Apr 16, 2024
Kaiido
reviewed
Apr 16, 2024
| @@ -121,6 +121,7 @@ | |||
| script.textContent = state.js; | |||
| document.body.appendChild(script); | |||
|
|
|||
| dispatchEvent(new Event("DOMContentLoaded")); | |||
There was a problem hiding this comment.
This should be fired on the document, not the window (technically even the load one below has a legacy retarget to doc). Don't forget to make it bubble then.
Kaiido
reviewed
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9324.
Fixes #9409.
Fixes #10310.
Fixes #10766.
Fixes #10771.
Fixes #10772.
Problem
The
DOMContentLoadedwasn't fired in the Playground, because the HTML is inserted only after the originalDOMContentLoadedevent is fired.Solution
Manually fire a
DOMContenLoadedevent, just like we manually fire aloadevent.Screenshots
Before
Prod: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#example
After
Stage: https://developer.allizom.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#example
How did you test this change?
Deployed this to change and tested the live sample at https://developer.allizom.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role#example, mentioned in #9324.