Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window load example regression #10771

Closed
wbamberg opened this issue Feb 12, 2024 · 6 comments · Fixed by #10770 or #10946
Closed

Window load example regression #10771

wbamberg opened this issue Feb 12, 2024 · 6 comments · Fixed by #10770 or #10946
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.

Comments

@wbamberg
Copy link
Collaborator

wbamberg commented Feb 12, 2024

The page for https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event has an example showing the order in which load and DOMContentLoaded events are fired. As recently as June 13, 2023 this example worked, but since the new live sample system launched it has stopped working.

Perhaps this is because in the new system DOMContentLoaded fires before the script runs.

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Feb 12, 2024
@wbamberg wbamberg changed the title MDN Play regressed Window load example Window load example regression Feb 13, 2024
@ShubhamOulkar
Copy link

ShubhamOulkar commented Feb 18, 2024

@caugner
Copy link
Contributor

caugner commented Mar 15, 2024

@wbamberg I suggest moving this over to yari, unless you would like to keep it here?

@wbamberg
Copy link
Collaborator Author

wbamberg commented Mar 15, 2024

I didn't move this to Yari so we can track it here if we want to work around it in content.

So I think whether to move it to Yari depends on how likely it is to get fixed in Yari, or whether content should work around it. Which also I guess depends on what the "contract" offered by the live sample system to content authors is. With so many live samples on MDN and so many subtleties around the system, it feels like a spec is needed if we are to avoid errors/regressions.

@wbamberg
Copy link
Collaborator Author

@caugner, this does not seem to be fixed by #10770 .

@wbamberg wbamberg reopened this Apr 16, 2024
@caugner
Copy link
Contributor

caugner commented Apr 16, 2024

@wbamberg Works for me. Please open a new issue for the problem you're experiencing.

@caugner caugner closed this as completed Apr 16, 2024
@wbamberg
Copy link
Collaborator Author

For this example: https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event#live_example

...in the output I see this:

Screen Shot 2024-04-16 at 4 13 05 PM

...in the pre-Playground version (https://web.archive.org/web/20230322100016/https://developer.mozilla.org/en-US/docs/Web/API/Window/load_event#live_example) I see this:

Screen Shot 2024-04-16 at 4 14 31 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened.
Projects
None yet
3 participants