Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(macros/LearnSidebar): add Japanese translation retake #10019

Conversation

gurezo
Copy link
Contributor

@gurezo gurezo commented Nov 13, 2023

Summary

this PR is retake PR #9829

@hmatrjp @potappo

Problem

still en-us only

Solution

translate japanese for LearnSidebar.ejs

NOTICE

alreday mdn/translated-content#16543 merged.

Before

still en-us only

After

add tranlate japanese for LearnSidebar.ejs

memo

to @caugner
Please merge once mdn-yari-ja is approved.

BEGIN_COMMIT_OVERRIDE
chore(macros/LearnSidebar): add Japanese translation retake
END_COMMIT_OVERRIDE

@gurezo gurezo requested a review from a team as a code owner November 13, 2023 14:11
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Nov 13, 2023
@caugner caugner requested review from a team and kenji-yamasaki and removed request for a team December 4, 2023 16:58
Copy link
Contributor

@hmatrjp hmatrjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the retake, with the fix upon with my request on PR #9829.

And also, thank you for your waiting.

@hmatrjp
Copy link
Contributor

hmatrjp commented Dec 23, 2023

Now your turn please, @caugner

@github-actions github-actions bot added the idle label Jan 24, 2024
@gurezo
Copy link
Contributor Author

gurezo commented Mar 23, 2024

@caugner ping
please this PR review

@caugner caugner merged commit 40be4dd into mdn:main Mar 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idle macros tracking issues related to kumascript macros needs review from l10n teams
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants