Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(css): Add example of :modal #2316

Merged
merged 3 commits into from
Jul 22, 2023
Merged

feat(css): Add example of :modal #2316

merged 3 commits into from
Jul 22, 2023

Conversation

NiedziolkaMichal
Copy link
Member

This PR adds interactive example to :modal.

image

@bsmth bsmth changed the title modal Add CSS :modal pseudo class Dec 7, 2022
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Jan 7, 2023
@NiedziolkaMichal NiedziolkaMichal mentioned this pull request Feb 10, 2023
Open
94 tasks
@NiedziolkaMichal NiedziolkaMichal changed the title Add CSS :modal pseudo class feat(css): Add example of :modal Feb 26, 2023
@NiedziolkaMichal NiedziolkaMichal removed depends on shadow DOM fix idle Issues and pull requests with no activity for three months. labels Feb 26, 2023
@github-actions github-actions bot added the idle Issues and pull requests with no activity for three months. label Mar 29, 2023
@sideshowbarker
Copy link
Collaborator

At https://github.com/mdn/interactive-examples/actions/runs/5632002837/job/15259572637?pr=2316#step:6:11 there is a CI failure:

8:1 ✖ Unexpected unknown pseudo-class selector ":modal" selector-pseudo-class-no-unknown

…but the reason for that is, https://github.com/mdn/interactive-examples/blob/1d69481229781284b699d4e7ea118b8dae218939/package.json#L50C24-L50C31 shows that we may be using an old version of stylelint — version 14.16.1 from Dec 29, 2022 — and we instead need to be using at least version 15.6.1 from May 3, 2023, which contains this fix:

Fixed: selector-pseudo-class-no-unknown false positive for :modal (#6811)

@sideshowbarker sideshowbarker merged commit 173563a into main Jul 22, 2023
4 of 5 checks passed
@sideshowbarker sideshowbarker deleted the modal branch July 22, 2023 18:20
@mdn-bot mdn-bot mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

Assignees
No one assigned
Labels
idle Issues and pull requests with no activity for three months.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NiedziolkaMichal @sideshowbarker