Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome 60 and Firefox 59 set relatedTarget on DragEvent #25703

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Chrome 60 and Firefox 59 set relatedTarget on DragEvent #25703

merged 3 commits into from
Jan 23, 2025
+36 −0

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 17, 2025

Summary

Chrome 60 and Firefox 59 set relatedTarget on DragEvent, but Safari doesn't.

Test results and supporting details

Bugs:

Related issues

Fixes #16871.

@caugner
Chrome 60 and Firefox 59 set relatedTarget on DragEvent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
7661dc5
@caugner caugner requested a review from Elchi3 January 17, 2025 22:08
@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed labels Jan 17, 2025
Elchi3
Elchi3 requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, DragEvent has no member called relatedTarget, right? It lives on MouseEvent and so this data shouldn't be added I think?

@caugner
Copy link
Contributor Author

caugner commented Jan 22, 2025 •
edited
Loading

So, DragEvent has no member called relatedTarget, right? It lives on MouseEvent and so this data shouldn't be added I think?

@Elchi3 Good point, would you rather add this data as a subfeature below MouseEvent.relatedTarget (one for each event name, or just one for drag events), or using notes?

@caugner
fixup! Chrome 60 and Firefox 59 set relatedTarget on DragEvent

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2ae2d3f
@caugner caugner force-pushed the 16781-DragEvent-relatedTarget branch from 169163a to 2ae2d3f Compare January 22, 2025 22:57
@Elchi3
Copy link
Member

Elchi3 commented Jan 23, 2025

A sub feature drag_events below MouseEvent.relatedTarget seems useful to me.

@caugner
Copy link
Contributor Author

caugner commented Jan 23, 2025

A sub feature drag_events below MouseEvent.relatedTarget seems useful to me.

Fixed in 1505afb.

@Elchi3 Elchi3 merged commit c6a3241 into main Jan 23, 2025
11 checks passed
@Elchi3 Elchi3 deleted the 16781-DragEvent-relatedTarget branch January 23, 2025 14:59
@mdn-bot mdn-bot mentioned this pull request Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API size:m [PR only] 25-100 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

api.MouseEvent.relatedTarget - Browser compatibility
2 participants
@caugner @Elchi3