Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing __compat+mdn_url to top-level extension namespaces #22338

Merged
merged 3 commits into from Mar 8, 2024

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Feb 29, 2024

Summary

Add __compat and missing mdn_url` to every extension API namespace that lacks such an entry at the API namespace level. Also fixed up some individual entries.

To populate the __compat objects, I copied and pasted an existing entry from another API entry within the file (ideally the oldest supported entry where possible), then modified the support state. I used my knowledge of Chrome and Firefox extension API support to resolve non-trivial cases. E.g. search.search and search.query have different support ranges in Firefox and Chrome, but the namespace they belong to (search) is set to the earliest version that supports either method.

The contextualIdentities entry has a note on Android compat, for consistency with the other entries as added in #22337, generated by #22337 (comment)

Test results and supporting details

Related issues

@github-actions github-actions bot added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 29, 2024
@Rob--W Rob--W force-pushed the webext-top-level-__compat branch 3 times, most recently from 652856e to 1998c6f Compare February 29, 2024 13:47
@Rob--W
Copy link
Member Author

Rob--W commented Feb 29, 2024

CI is failing because the contextualIdentities entry depends on the fixup from #22337. I'll rebase this PR when the other gets merged.

And after adding __compat, suddenly the style linter complains about the ordering of some keys. I'll fix that before merging, perhaps by running npm run fix

@Rob--W
Copy link
Member Author

Rob--W commented Feb 29, 2024

Another note: after adding the top-level compat info, the linter complained about incorrect entries in between. E.g. Safari liststs devtools API methods but missed entries at the individual subnamespaces. I fixed these too.

In tabs.json, executeScript was flagged as supported in 43. I bumped it to 45 for consistency with the others. I think that the support status is based on when the schema landed, which is in 45: https://hg.mozilla.org/mozilla-central/rev/7b0f6544f9b6b18c87e0bcacc215726a5804f2f2
In reality, large chunks of the tabs API already landed before in 42: https://hg.mozilla.org/mozilla-central/rev/0364858aed56#l5.3

@github-actions github-actions bot added the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 3, 2024
Copy link

github-actions bot commented Mar 3, 2024

This pull request has merge conflicts that must be resolved before it can be merged.

@Rob--W Rob--W force-pushed the webext-top-level-__compat branch from 9e96887 to 79dc5ec Compare March 4, 2024 00:19
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Mar 4, 2024
@Rob--W Rob--W requested review from rebloor and rpl March 4, 2024 00:21
Copy link
Collaborator

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W I've done a spot check for URLs and version information, everything looks OK, let me know if I should be doing comprehensive check.

@Rob--W
Copy link
Member Author

Rob--W commented Mar 8, 2024

@Rob--W I've done a spot check for URLs and version information, everything looks OK, let me know if I should be doing comprehensive check.

Let's merge it.

@rebloor rebloor merged commit 66100af into mdn:main Mar 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants