Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tabs.Tab properties update #22229

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented Feb 14, 2024

Summary

Update to tabs.Tab properties including:

  • addition of attention - missing property supported in Firefox (could trace support back to Firefox 65 but was clearly implemented earlier, blame was failing to backtrack on show earliest version with this line.)
  • addition of groupId and pendingUrl - missing properties supported in Chrome
  • update to lastAccessed – now supported in Chrome as of 121

Related issues

Fixes mdn/content#22275
Related mdn documentation updates in mdn/content#32279

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label Feb 14, 2024
@rebloor rebloor self-assigned this Feb 14, 2024
* removed Chrome only groupId
* added implementation URL for pendingUrl
@rebloor rebloor requested a review from Rob--W March 8, 2024 17:48
},
"edge": "mirror",
"firefox": {
"version_added": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version_added": true
"version_added": "63"

version 63, source: https://bugzilla.mozilla.org/show_bug.cgi?id=1396684

To find this, I repeatedly used the "annotated diff" feature in the sidebar while searching for "attention" . I started at https://searchfox.org/mozilla-central/rev/d572999cdc8f41591ce2f4d0b13486cc9aad2123/browser/components/extensions/schemas/tabs.json#220 and ended at https://searchfox.org/mozilla-central/diff/180811af326c308b68f52ef45146644b02ffe378/browser/components/extensions/schemas/tabs.json#105

"firefox": {
"version_added": true
},
"firefox_android": "mirror",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In practice not supported on Android. The property exists but is always false.

Note: tabs.query needs an entry with the same version number, for the option queryInfo.attention, supported on Firefox 63+, and not supported at all on Android.

@@ -905,7 +924,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": false
"version_added": "121"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rob--W so are you suggesting we shouldn't rely solely on the Chrome documentation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can continue to rely on Chrome's doc. I was adding a source to confirm that the feature has indeed landed and is available there. Inaccuracies in Chrome's documentation has happened before, and since this was only one change I decided to double-check.

@rebloor rebloor requested a review from Rob--W March 11, 2024 01:15
@@ -905,7 +924,7 @@
"__compat": {
"support": {
"chrome": {
"version_added": false
"version_added": "121"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can continue to rely on Chrome's doc. I was adding a source to confirm that the feature has indeed landed and is available there. Inaccuracies in Chrome's documentation has happened before, and since this was only one change I decided to double-check.

webextensions/api/tabs.json Outdated Show resolved Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
@rebloor rebloor merged commit a09397e into mdn:main Mar 13, 2024
6 checks passed
@rebloor rebloor deleted the Align-tabs.Tab-properties-with-Chrome branch March 13, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type definitions do not match for Tab
2 participants