Add runtime.onPerformanceWarning #22196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebloor
added
the
data:webext 🎲
Rob--W
approved these changes
Mar 4, 2024
queengooborg
approved these changes
Mar 12, 2024
|
@queengooborg please don't merge these items for me - in this case there is still an ongoing discussion about the content |
|
Sorry, I saw Rob approved the PR so I merged it. If there's still an ongoing discussion, this PR should have been marked as a draft or otherwise had a signal that it wasn't ready to be merged. |
|
This BCD did not require further discussion so it was ready to merge. The version support ranges are accurate. |
|
@Rob--W but if the types are being documented, don't they need to be added? |
Yes they should. Without documentation, the BCD would link to a non-existing page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds compatibility details for the
runtime.on performanceevent introduced by Bug 1861445 Add new hang warning event API for WebExtensionswarning.See mdn/content#32222 for the MDN content update.