Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Feature-Policy HTTP header from BCD #20328

Merged

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jul 10, 2023

This PR removes the Feature-Policy HTTP header from BCD. This fixes #9556 by removing the old file for Feature-Policy, which has already been folded into the new Permissions-Policy header.

Verified

This commit was signed with the committer’s verified signature.
queengooborg Queen Vinyl Da.i'gyu-Kazotetsu
This PR removes the `Feature-Policy` HTTP header from BCD. This fixes mdn#9556 by removing the old file for `Feature-Policy`, which has already been folded into the new `Permissions-Policy` header.

Tests Used: https://mdn-bcd-collector.gooborg.com/tests/http/headers/Feature-Policy
@queengooborg queengooborg added data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Jul 10, 2023
@hamishwillee
Copy link
Contributor

Any reason not to merge this?

@queengooborg
Copy link
Contributor Author

Not that I would know of, I've just been waiting on approval before making the content changes and merging.

@hamishwillee
Copy link
Contributor

I can't grant approval. But content is changed earlier in the year or even last year.

@Elchi3 Elchi3 added merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. and removed needs content update This PR needs a corresponding update to mdn/content to update the documentation labels Sep 22, 2023

Verified

This commit was signed with the committer’s verified signature.
queengooborg Queen Vinyl Da.i'gyu-Kazotetsu
@github-actions github-actions bot removed the merge conflicts 🚧 This PR needs to merge latest "main" branch to resolve a merge conflict or other issue. label Sep 27, 2023
@queengooborg queengooborg merged commit 5842721 into mdn:main Sep 27, 2023
@queengooborg queengooborg deleted the http/headers/Feature-Policy/removal branch September 27, 2023 03:26
@hamishwillee
Copy link
Contributor

Hurray!

Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023

Partially verified

This commit is signed with the committer’s verified signature.
Elchi3’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
This PR removes the `Feature-Policy` HTTP header from BCD. This fixes mdn#9556 by removing the old file for `Feature-Policy`, which has already been folded into the new `Permissions-Policy` header.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Feature Policy" has been renamed "Permissions Policy"
3 participants