chore(deps): Remove rimraf (bcoe#509)

feat(deps): use Node.js built in rm feat(build)!: minimum Node.js version is now 14.14.0
mcknasty · Jan 3, 2024 · a3755f6 · a3755f6
1 parent c5b78a5
commit a3755f6
Show file tree

Hide file tree

Showing 5 changed files with 2,245 additions and 1,429 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -12,10 +12,10 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        node: [12, 14, 16, 18]
+        node: [14, 16, 18, 20]
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: ${{ matrix.node }}
           cache: npm
@@ -24,8 +24,8 @@ jobs:
   windows:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: lts/*
           cache: npm
@@ -34,8 +34,8 @@ jobs:
   coverage:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
-      - uses: actions/setup-node@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
         with:
           node-version: lts/*
           cache: npm

diff --git a/bin/c8.js b/bin/c8.js
@@ -3,9 +3,7 @@
 
 const foreground = require('foreground-child')
 const { outputReport } = require('../lib/commands/report')
-const { promises } = require('fs')
-const { promisify } = require('util')
-const rimraf = require('rimraf')
+const { rm, mkdir } = require('fs/promises')
 const {
   buildYargs,
   hideInstrumenteeArgs,
@@ -21,18 +19,11 @@ async function run () {
   ].indexOf(argv._[0]) !== -1) {
     argv = buildYargs(true).parse(process.argv.slice(2))
   } else {
-    // fs.promises was not added until Node.js v10.0.0, if it doesn't
-    // exist, assume we're Node.js v8.x and skip coverage.
-    if (!promises) {
-      foreground(hideInstrumenterArgs(argv))
-      return
-    }
-
     if (argv.clean) {
-      await promisify(rimraf)(argv.tempDirectory)
+      await rm(argv.tempDirectory, { recursive: true, force: true })
     }
 
-    await promises.mkdir(argv.tempDirectory, { recursive: true })
+    await mkdir(argv.tempDirectory, { recursive: true })
     process.env.NODE_V8_COVERAGE = argv.tempDirectory
     foreground(hideInstrumenterArgs(argv), async (done) => {
       try {