Merge pull request #218 from mberlanda/job-cc

test: increase jobs code coverage

app/jobs/mailchimp_job.rb

@@ -4,9 +4,8 @@ class MailchimpJob < ApplicationJob
   queue_as :default
 
   def perform(*users_to_add)
-    gibbon = Gibbon::Request.new
     users_to_add.each do |u|
-      gibbon.lists(Mailchimp.list_id).members(calculate_id(u)).upsert(
+      gibbon_request.lists(Mailchimp.list_id).members(calculate_id(u)).upsert(
         **format_user_body(u)
       )
       u.update(mailing_listed: true)
@@ -15,6 +14,10 @@ def perform(*users_to_add)
     end
   end
 
+  def gibbon_request
+    @gibbon_request ||= Gibbon::Request.new
+  end
+
   private
 
   def calculate_id(u)

spec/jobs/mailchimp_job_spec.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+RSpec.describe MailchimpJob do
+  let(:job) { described_class.new }
+  let(:user) { FactoryBot.create(:user) }
+
+  before do
+    allow(Mailchimp).to receive(:calculate_id).and_return(123_456)
+  end
+
+  context 'when response successfull' do
+    it 'updates user mailing_listed attribute' do
+      expect(user.mailing_listed).to eq(false)
+
+      allow(job.gibbon_request).to receive(:upsert).and_return(true)
+      job.perform(user)
+
+      expect(user.mailing_listed).to eq(true)
+    end
+  end
+
+  context 'when response is an error' do
+    it 'does not update user mailing_listed attribute' do
+      expect(user.mailing_listed).to eq(false)
+
+      allow(job.gibbon_request).to receive(:upsert).and_raise(Gibbon::MailChimpError)
+      job.perform(user)
+
+      expect(user.mailing_listed).to eq(false)
+    end
+  end
+end