fix raszi#268: Revert "fix raszi#246: remove any double quotes or sin…

…gle quotes from os.tmpdir also sanitize dir option, the template option and the name option"

This reverts commit c8823e5.

Single quotes must not be removed from paths because they are valid (even if hard to use)
on all OSes. Double quotes are only disallowed on Windows, but tmp should not change any
arg it gets; instead, it should rely on the underlying fs API to fail with an error
that the user needs to fix.

lib/tmp.js

@@ -535,7 +535,7 @@ function _assertAndSanitizeOptions(options) {
   options.template = _isBlank(options.template) ? undefined : path.relative(options.dir, options.template);
 
   // for completeness' sake only, also keep (multiple) blanks if the user, purportedly sane, requests us to
-  options.name = _isUndefined(options.name) ? undefined : _sanitizeName(options.name);
+  options.name = _isUndefined(options.name) ? undefined : options.name;
   options.prefix = _isUndefined(options.prefix) ? '' : options.prefix;
   options.postfix = _isUndefined(options.postfix) ? '' : options.postfix;
 }
@@ -552,28 +552,13 @@ function _assertAndSanitizeOptions(options) {
  * @private
  */
 function _resolvePath(name, tmpDir) {
-  const sanitizedName = _sanitizeName(name);
-  if (sanitizedName.startsWith(tmpDir)) {
-    return path.resolve(sanitizedName);
+  if (name.startsWith(tmpDir)) {
+    return path.resolve(name);
   } else {
-    return path.resolve(path.join(tmpDir, sanitizedName));
+    return path.resolve(path.join(tmpDir, name));
   }
 }
 
-/**
- * Sanitize the specified path name by removing all quote characters.
- *
- * @param name
- * @returns {string}
- * @private
- */
-function _sanitizeName(name) {
-  if (_isBlank(name)) {
-    return name;
-  }
-  return name.replace(/["']/g, '');
-}
-
 /**
  * Asserts whether specified name is relative to the specified tmpDir.
  *
@@ -663,7 +648,7 @@ function setGracefulCleanup() {
  * @returns {string} the currently configured tmp dir
  */
 function _getTmpDir(options) {
-  return path.resolve(_sanitizeName(options && options.tmpdir || os.tmpdir()));
+  return path.resolve(options && options.tmpdir || os.tmpdir());
 }
 
 // Install process exit listener

test/name-sync-test.js

@@ -7,7 +7,6 @@ const
   inbandStandardTests = require('./name-inband-standard'),
   tmp = require('../lib/tmp');
 
-const isWindows = os.platform() === 'win32';
 
 describe('tmp', function () {
   describe('#tmpNameSync()', function () {
@@ -40,9 +39,7 @@ describe('tmp', function () {
       describe('on issue #176', function () {
         const origfn = os.tmpdir;
         it('must fail on invalid os.tmpdir()', function () {
-          os.tmpdir = function () {
-            return undefined;
-          };
+          os.tmpdir = function () { return undefined; };
           try {
             tmp.tmpNameSync();
             assert.fail('should have failed');
@@ -53,35 +50,6 @@ describe('tmp', function () {
           }
         });
       });
-      describe('on issue #246', function () {
-        const origfn = os.tmpdir;
-        it('must produce correct name on os.tmpdir() returning path that includes double quotes', function () {
-          const tmpdir = isWindows ? '"C:\\Temp With Spaces"' : '"/tmp with spaces"';
-          os.tmpdir = function () {
-            return tmpdir;
-          };
-          const name = tmp.tmpNameSync();
-          try {
-            assert.ok(name.indexOf('"') === -1);
-            assert.ok(name.startsWith(tmpdir.replace(/["']/g, '')));
-          } finally {
-            os.tmpdir = origfn;
-          }
-        });
-        it('must produce correct name on os.tmpdir() returning path that includes single quotes', function () {
-          const tmpdir = isWindows ? '\'C:\\Temp With Spaces\'' : '\'/tmp with spaces\'';
-          os.tmpdir = function () {
-            return tmpdir;
-          };
-          const name = tmp.tmpNameSync();
-          try {
-            assert.ok(name.indexOf('\'') === -1);
-            assert.ok(name.startsWith(tmpdir.replace(/["']/g, '')));
-          } finally {
-            os.tmpdir = origfn;
-          }
-        });
-      });
     });
 
     describe('when running standard outband tests', function () {

test/name-test.js

@@ -7,7 +7,6 @@ const
   inbandStandardTests = require('./name-inband-standard'),
   tmp = require('../lib/tmp');
 
-const isWindows = os.platform() === 'win32';
 
 describe('tmp', function () {
   describe('#tmpName()', function () {
@@ -63,39 +62,6 @@ describe('tmp', function () {
           });
         });
       });
-      describe('on issue #246', function () {
-        const origfn = os.tmpdir;
-        it('must produce correct name on os.tmpdir() returning path that includes double quotes', function (done) {
-          const tmpdir = isWindows ? '"C:\\Temp With Spaces"' : '"/tmp with spaces"';
-          os.tmpdir = function () { return tmpdir; };
-          tmp.tmpName(function (err, name) {
-            try {
-              assert.ok(name.indexOf('"') === -1);
-              assert.ok(name.startsWith(tmpdir.replace(/["']/g, '')));
-            } catch (err) {
-              return done(err);
-            } finally {
-              os.tmpdir = origfn;
-            }
-            done();
-          });
-        });
-        it('must produce correct name on os.tmpdir() returning path that includes single quotes', function (done) {
-          const tmpdir = isWindows ? '\'C:\\Temp With Spaces\'' : '\'/tmp with spaces\'';
-          os.tmpdir = function () { return tmpdir; };
-          tmp.tmpName(function (err, name) {
-            try {
-              assert.ok(name.indexOf('\'') === -1);
-              assert.ok(name.startsWith(tmpdir.replace(/["']/g, '')));
-            } catch (err) {
-              return done(err);
-            } finally {
-              os.tmpdir = origfn;
-            }
-            done();
-          });
-        });
-      });
     });
 
     describe('when running standard outband tests', function () {
@@ -105,3 +71,4 @@ describe('tmp', function () {
     });
   });
 });
+