use font-awesome icons for close/open #644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryvdh
commented
Apr 2, 2024
| this.$closebtn = $('<a />').addClass(csscls('close-btn')).appendTo(this.$headerRight); | ||
| this.$closebtn = $('<a/>').addClass(csscls('close-btn')) | ||
| .append($('<i />').attr('class', 'phpdebugbar-fa phpdebugbar-fa-times')) | ||
| .css('background', 'none') |
There was a problem hiding this comment.
This is more as a 'fallback' to avoid duplicate styling for existing integrations..
|
I merged #645 in this and added a text-align to achieve the same effect. Not sure if this is better though, we could just use the svg's now that they are centered, and override the fill. |
|
Don't think we need this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't really change much, but cleaner and easier to style (background-color) in themes (eg for Laravel debugbar)
