New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataset tab instead of dropdown #627
Conversation
@erikn69 @parallels999 any thoughts about this approach? |
Yeah sorting could be changed but if newer are on top, the list keeps changing while you are browsing it. Maybe we could just toggle it when you click on the header. Right now it shows the uri value from the meta data. It might be possible to show a bit more description, eg. for livewire a component or something, but not sure what the best way it. |
That is a good question. But we could still show the name in the tab on the right, just like the dropdown |
With dropdown is easier to compare a tab data between requests, with a specific tab you would have to go to the tab, select the request you are looking for and return to the tab with the data |
Looks better, but if i want to look Also, How to know if the calls are ajax or normal calls, previously even the calls coming from the iframe have a label |
The switching to same tab is a valid point, but mostly handled by the badges, which direct you to the correct tab. I added the suffix to the tab label, but I think almost always the requests are ajax, except for the first one? (or maybe the first 2 in case of a redirect). An alternative could be a popup like the open handler, but I kinda like that you can see the incoming requests. (But that add the question again if the order might be reversed) |
Are Iframes considered ajax?
To me, yes, But for many people that part is confusing. |
Looks great to me, but I think it would look better with reversed items, so you could always see the last one |
Not really sure about what to do when clicking though. Now it is:
Not sure if there is a case where you would want to keep the tab open after clicking on a dataset though. |
Feels a bit weird though, think staying on page is better. Gonna try this out somewhere. |
And made it configurable by now, disabled by default (might set default in the future) |
Current dropdown has the following issues:
So the idea is this:
Rough prototype in PR:
Thoughts: