Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make font-awesome css a single file #624

Merged
merged 2 commits into from
Mar 14, 2024
Merged

Conversation

parallels999
Copy link
Contributor

Make font-awesome css a single file using base64,
This makes it easier to extend DebugBar\JavascriptRenderer, without this i get file not found on browser
At least until it is removed #598

@barryvdh
Copy link
Collaborator

So this is just the woff that base64 encoded right? Guess we don't need the rest anway.

@barryvdh
Copy link
Collaborator

Ah yes this is what I do with laravel-debugbar also; https://github.com/barryvdh/laravel-debugbar/blob/master/src/Resources/vendor/font-awesome/style.css

@barryvdh barryvdh merged commit f259c92 into maximebf:master Mar 14, 2024
7 checks passed
@parallels999
Copy link
Contributor Author

parallels999 commented Mar 14, 2024

Ah yes this is what I do with laravel-debugbar also; https://github.com/barryvdh/laravel-debugbar/blob/master/src/Resources/vendor/font-awesome/style.css

So, you could delete that file and upstream to this for upgrade Font Awesome
This package uses Font Awesome 4.7 minified, and laravel-debugbar use Font Awesome 4.3

* Font Awesome 4.7.0 by @davegandy - http://fontawesome.io - @fontawesome

barryvdh/laravel-debugbar/src/Resources/vendor/font-awesome/style.css#L2

@barryvdh
Copy link
Collaborator

Yeah indeed. Not sure why I didn't just do that here in the first place as well though :P

@barryvdh
Copy link
Collaborator

barryvdh commented Apr 1, 2024

Done in barryvdh/laravel-debugbar#1596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants