Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection filter on sqls widget #622

Merged
merged 1 commit into from Mar 14, 2024
Merged

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 13, 2024

Each new ajax page could bring new connections
The connections accumulate, and appear in all records, even if no SQL exists with that connection


Fix a css problem
image

image

this.$toolbar.find(csscls('.filter') + csscls('.excluded')).each(function() {
excludedLabels.push(this.rel);
});

Copy link
Contributor Author

@erikn69 erikn69 Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did remove this code because it does nothing, seems like a copy/paste issue

onFilterClick: function(el) {
$(el).toggleClass(csscls('excluded'));
var excludedLabels = [];
this.$toolbar.find(csscls('.filter') + csscls('.excluded')).each(function() {
excludedLabels.push(this.rel);
});
this.set('exclude', excludedLabels);
}

@barryvdh barryvdh merged commit 9138c11 into maximebf:master Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants