Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter collectors on MessagesWidget #616

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Mar 11, 2024

  • This PR adds a second filter group to MessageCollector, MessageCollector could aggreate other MessagesAggregateInterface, With this PR it is easier to filter messages from a certain collector(#1560)
  • Another problem that is solved is if there is only one label/collector, it is not necessary to add the filter, because it removes/displays all the messages
  • In case there are unlabeled messages, the NONE filter is added, which allows them to be filtered; previously it was not possible to filter this type of messages
  • There was a CSS problem, the bottom only took into account the search bar, but not the filters, sometimes the filters obstruct the view of the message, I did increase enough padding to display correctly

image

@barryvdh barryvdh merged commit bce78f9 into maximebf:master Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants