Improve assertion and ignore cached PHPUnit file #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter279k
commented
Dec 9, 2020
| @@ -17,7 +17,7 @@ public function testAddCollector() | |||
| $this->c->addCollector($c = new MockCollector()); | |||
| $this->assertContains($c, $this->c->getCollectors()); | |||
| $this->assertEquals($c, $this->c['mock']); | |||
| $this->assertTrue(isset($this->c['mock'])); | |||
| $this->assertArrayHasKey('mock', $this->c); | |||
There was a problem hiding this comment.
Using the assertArrayHasKey to assert the expected key is on the result array.
peter279k
commented
Dec 9, 2020
| @@ -33,16 +33,16 @@ public function testStartStopMeasure() | |||
| $this->assertEquals('bar', $m[0]['label']); | |||
| $this->assertEquals('baz', $m[0]['collector']); | |||
| $this->assertEquals(array('bar' => 'baz'), $m[0]['params']); | |||
| $this->assertTrue($m[0]['start'] < $m[0]['end']); | |||
| $this->assertLessThan($m[0]['end'], $m[0]['start']); | |||
There was a problem hiding this comment.
Using the assertLessThan to assert expected and result comparison.
peter279k
commented
Dec 9, 2020
| $this->assertTrue($data['end'] > $this->s); | ||
| $this->assertTrue($data['duration'] > 0); | ||
| $this->assertGreaterThan($this->s, $data['end']); | ||
| $this->assertGreaterThan(0, $data['duration']); |
There was a problem hiding this comment.
Using the assertGreaterThan to assert expected and result comparison.
peter279k
commented
Dec 9, 2020
| @@ -96,7 +96,7 @@ public function testStackedData() | |||
| $data = $this->debugbar->getStackedData(); | |||
| $this->assertArrayNotHasKey($ns, $http->session); | |||
| $this->assertArrayHasKey($id, $data); | |||
| $this->assertEquals(1, count($data)); | |||
| $this->assertCount(1, $data); | |||
There was a problem hiding this comment.
Using the assertCount to assert expected is same as result count.
peter279k
commented
Dec 9, 2020
| @@ -17,13 +17,13 @@ public function setUp(): void | |||
| public function assertJsonIsArray($json) | |||
| { | |||
| $data = json_decode($json); | |||
| $this->assertTrue(is_array($data)); | |||
| $this->assertIsArray($data); | |||
There was a problem hiding this comment.
Using the assertIsArray to assert expected type is array type.
peter279k
commented
Dec 9, 2020
| } | ||
|
|
||
| public function assertJsonIsObject($json) | ||
| { | ||
| $data = json_decode($json); | ||
| $this->assertTrue(is_object($data)); | ||
| $this->assertIsObject($data); |
There was a problem hiding this comment.
Using the assertIsObject to assert expected type is object.
peter279k
force-pushed
the
test_enhancement
branch
from
167eb0e
to
847dd04
Compare
parallels999
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed log
.phpunit.result.cachefile be on.gitignorefile and this is generated byPHPUnit 9.x.version.