Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeps only the main debugbar functionality on iframes #606

Merged
merged 1 commit into from Mar 1, 2024

Conversation

erikn69
Copy link
Contributor

@erikn69 erikn69 commented Feb 26, 2024

Alternative to #452 (comment)

We needed a way to add them to the debugbar. (a bit like it happens with ajax+headers).
The debugbar is opened in the top frame, and when something happens inside the iframes, the changes are being added to the top-level debugbar.

image
Some iframes may be hidden or small, this PR propagates data from iframes to the top main debugbar and also it prevents size errors caused by small iframes(the inside smaller iframe change web storage like height, that affects the main debugbar)

@barryvdh barryvdh merged commit b6113ae into maximebf:master Mar 1, 2024
7 checks passed
barryvdh added a commit that referenced this pull request Mar 11, 2024
barryvdh added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants