Feat deprecate bindtojquery (#629)

* Deprecate bindToJquery * Tweak
maximebf · Mar 20, 2024 · 42beef0 · 42beef0
1 parent 3668109
commit 42beef0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/src/DebugBar/JavascriptRenderer.php b/src/DebugBar/JavascriptRenderer.php
@@ -72,9 +72,9 @@ class JavascriptRenderer
 
     protected $ajaxHandlerBindToFetch = false;
 
-    protected $ajaxHandlerBindToJquery = true;
+    protected $ajaxHandlerBindToJquery = false;
 
-    protected $ajaxHandlerBindToXHR = false;
+    protected $ajaxHandlerBindToXHR = true;
 
     protected $ajaxHandlerAutoShow = true;
 
@@ -509,6 +509,7 @@ public function isAjaxHandlerBoundToFetch()
      * Sets whether to call bindToJquery() on the ajax handler
      *
      * @param boolean $bind
+     * @deprecated use setBindAjaxHandlerToXHR
      */
     public function setBindAjaxHandlerToJquery($bind = true)
     {
@@ -520,6 +521,7 @@ public function setBindAjaxHandlerToJquery($bind = true)
      * Checks whether bindToJquery() will be called on the ajax handler
      *
      * @return boolean
+     * @deprecated use isAjaxHandlerBoundToXHR
      */
     public function isAjaxHandlerBoundToJquery()
     {

diff --git a/src/DebugBar/Resources/debugbar.js b/src/DebugBar/Resources/debugbar.js
@@ -1204,10 +1204,7 @@ if (typeof(PhpDebugBar) == 'undefined') {
         },
 
         /**
-         * Attaches an event listener to jQuery.ajaxComplete()
-         *
-         * @this {AjaxHandler}
-         * @param {jQuery} jq Optional
+         * @deprecated use bindToXHR instead
          */
         bindToJquery: function(jq) {
             var self = this;

diff --git a/tests/DebugBar/Tests/full_init.html b/tests/DebugBar/Tests/full_init.html
@@ -9,5 +9,5 @@
 });
 phpdebugbar.restoreState();
 phpdebugbar.ajaxHandler = new PhpDebugBar.AjaxHandler(phpdebugbar, undefined, true);
-if (jQuery) phpdebugbar.ajaxHandler.bindToJquery(jQuery);
+phpdebugbar.ajaxHandler.bindToXHR();
 phpdebugbar.addDataSet(