[ruby] Update rubocop → 1.59.0 (unknown) #132
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 93.69% 93.69%
=======================================
Files 39 39
Lines 951 951
=======================================
Hits 891 891
Misses 60 60 ☔ View full report in Codecov by Sentry. |
|
There is still a problem with parentheses around condition: rubocop/rubocop#12537 |
|
@depfu rebase |
|
@depfu rebase |
|
Suppressed by #137 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.57.0 → ~> 1.59.0) · Repo · Changelog
Release Notes
1.59.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 60 commits:
Cut 1.59Update Changelog[Fix #12524] Fix a false positive for `Style/MethodCallWithArgsParentheses`Make `Style/MethodCallWithoutArgsParentheses` allow parenthesized `it`Make `Style/RedundantSelf` allow `self.it`[Fix #12526] Fix incorrect rendering typos[Fix #12444] Fix false positive for `Style/HashEachMethods`Add new `Lint/ItWithoutArgumentsInBlock` copMerge pull request #12521 from koic/make_style_select_by_regexp_aware_of_safe_navigation_operatorMerge pull request #12438 from koic/fix_a_false_positive_for_lint_literal_assignment_in_condition[Fix #12458] Make `Style/SelectByRegexp` cops aware of safe navigation operatorRevert "Make `Style/SingleArgumentDig` aware of safe navigation operator"Merge pull request #12513 from koic/fix_false_positives_for_style_redundant_parenthesesMerge pull request #12515 from koic/fix_an_incorrect_autocorrect_for_style_combinable_loopsMerge pull request #12439 from koic/fix_a_false_positive_for_lint_self_assignment[Fix #12442] Fix an incorrect autocorrect for `Style/CombinableLoops`[Fix #12436] Fix false positives for `Style/RedundantParentheses`[Fix #12489] Make `Lint/NextWithoutAccumulator` aware of safe navigation operator[Fix #12489] Make `Lint/HashCompareByIdentity` aware of safe navigation operator[Fix #12494] Make `Layout/SingleLineBlockChain` aware of safe navigation operator[Fix #12495] Make `Layout/RedundantLineBreak` aware of safe navigation operator[Fix #12486] Make `Style/RedundantArgument` aware of safe navigation operator[Fix #12484] Make `Style/Next` aware of safe navigation operator[Fix #12479] Make `Style/EachWithObject` aware of safe navigation operator[Fix #12480] Make `Style/ExactRegexpMatch` aware of safe navigation operator[Fix #12476] Make `Style/ConcatArrayLiterals` aware of safe navigation operator[Fix #12474] Make `Style/ConcatArrayLiterals` aware of safe navigation operator[Fix #12473] Make `Style/ClassCheck` aware of safe navigation operator[Fix #12469] Make `Style/UnpackFirst` aware of safe navigation operatorMerge pull request #12505 from koic/fix_a_false_positive_for_style_redundant_parenthesesFix a false positive for `Style/RedundantParentheses`[Fix #12454] Make `Style/RedundantFetchBlock` aware of safe navigation operator[Fix #12455] Make `Style/RedundantSort` aware of safe navigation operator[Fix #12456] Make `Style/RedundantSortBy` aware of safe navigation operator[Fix #12457] Make `Style/Sample` aware of safe navigation operator[Fix #12460] Make `Style/SingleArgumentDig` aware of safe navigation operator[Fix #12468] Make `Style/Strip` aware of safe navigation operator[Fix #12461] Make `Style/StringChars` aware of safe navigation operator[Fix #12490] Make `Lint/NumberConversion` aware of safe navigation operator[Fix #12491] Make `Lint/RedundantWithIndex` aware of safe navigation operator[Fix #12492] Make `Lint/RedundantWithObject` aware of safe navigation operator[Fix #12493] Make `Lint/UnmodifiedReduceAccumulator` aware of safe navigation operatorMerge pull request #12452 from koic/make_style_map_compact_with_conditional_block_aware_of_safe_navigation_operatorMerge pull request #12451 from koic/make_style_hash_except_aware_of_safe_navigation_operatorMerge pull request #12450 from koic/make_style_collection_compact_aware_of_safe_navigation_operator[Fix #12447] Make `Style/MapCompactWithConditionalBlock` aware of safe navigation operator[Fix #12446] Make `Style/HashExcept` aware of safe navigation operator[Fix #12445] Make `Style/CollectionCompact` aware of safe navigation operatorMerge pull request #12449 from masato-bkn/fix-layout-heredocindentationMerge pull request #12443 from koic/fix_false_positives_for_style_hash_each_methodsMerge pull request #12431 from koic/tweak_autocorrect_for_style_map_to_hash[Fix #12441] Fix false positives for `Style/HashEachMethods`Merge pull request #12440 from ishigo974/masterCorrection: Style/ArrayFirstLast documentation typo[Fix #12434] Fix a false positive for `Lint/LiteralAssignmentInCondition`[Fix #12435] Fix a false positive for `Lint/SelfAssignment`[Fix #12429] Fix incorrect autocorrect for `Style/MapToHash`Merge pull request #12432 from koic/fix_false_positive_for_lint_literal_assignment_in_conditionFix false positive for `Lint/LiteralAssignmentInCondition`Switch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands