Skip to content

simplify computation of convert_children_as_inline variable #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

simplify computation of convert_children_as_inline variable #182

merged 1 commit into from
Feb 4, 2025
+7 −8

Conversation

chrispy-snps
Copy link
Collaborator

Simplifies the computation of the convert_children_as_inline:

  • Intermediate variables are replaced with a single short-circuiting expression.
  • First consideration is given to the incoming convert_as_inline flag.

@chrispy-snps
simplify computation of convert_children_as_inline variable
Loading
Loading status checks…
90f1f7a 
Signed-off-by: chrispy <chrispy@synopsys.com>
@chrispy-snps chrispy-snps requested a review from AlexVonB February 1, 2025 12:55
AlexVonB
AlexVonB approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@AlexVonB AlexVonB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables probably are artifacts from now-removed code -- good call!

@chrispy-snps chrispy-snps merged commit d0c4b85 into matthewwithanm:develop Feb 4, 2025
1 check passed
@chrispy-snps chrispy-snps deleted the chrispy/simplify-convert-as-inline branch February 17, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexVonB AlexVonB

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrispy-snps @AlexVonB