Added SmartOS / Solaris support. #5718
Conversation
|
Hi @siepkes, First, huge thanks for your interest in Mattermost and putting this together. Per our code contribution guidelines a change like this would typically go to the feature proposal forum and through extended discussion before a PR would be expected. One challenge is that everything that goes into the Mattermost server is either officially supported or on the way to being officially supported, and Solaris is in less demand than other platforms, E.g. FreeBSD has 118 votes right now in the feature proposal forum and even when the FreeBSD community has contributed changes to enable FreeBSD we've unfortunately been unable to accept.. That said, we have some vigorous discussion right now around this if you'd like to join. |
|
Closing because we have decided to not support this. (see above) |
Summary
I've added preliminary support for SmartOS / Solaris! This is interesting for people who want to run Mattermost on the Joyent Public Cloud (or private cloud with Triton like we do) or just on SmartOS.
Mattermost just works on SmartOS however fsnotify doesn't have support for FEN (The Solaris equivelant of Linux inotify). This leads to spamming of logs. There is actually an pull request open for FEN support in fsnotify (fsnotify/fsnotify#196). However this is not yet merged and also this code (unlike Linux, Windows and Darwin support) will only compile on Solaris. Which is kinda of a bummer for cross compiling. I think the the hot-swapping of templates is only done during development? Therefor I thought it would be better to just not support hot-template-reloading on Solaris and any other OS fsnotify might not support. It's just not worth the trouble of breaking cross compilation. I wanted to also add some documentation to make it obvious the Solaris build doesn't support hot-swapping templates but I couldn't find any documentation regarding template hot-swapping (so there was nothing to modify).
Ticket Link
I tried to create a Jira account so I could create a JIRA issue (as per procedure) but logging in to Atlassian cloud proved troublesom. I couldn't login with GitHub (only Google). I then tried to create an account and apparently I already had one so I tried to reset my password. That lead to an E-Mail with a link which displayed the following error when I clicked on it:
Illegal request-target, unexpected character '=' at position 471. No idea what it is but it seems like a nice attack vector ;-). Anywho at that point I gave up trying to create a JIRA ticket.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]