CLD-7165 Bump MacOS runner version #7828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvitale1989
added
Build App for iOS
mvitale1989
added
Build App for iOS
yasserfaraazkhan
added
Build App for iOS
mvitale1989
added
Build App for iOS
mvitale1989
added
Build App for iOS
mvitale1989
added
Build App for iOS
enahum
reviewed
Feb 16, 2024
enahum
reviewed
Feb 16, 2024
enahum
reviewed
Feb 16, 2024
enahum
reviewed
Feb 16, 2024
mvitale1989
added
Build Apps for PR
mvitale1989
added
Build Apps for PR
enahum
requested changes
Feb 21, 2024
mvitale1989
added
Build Apps for PR
larkox
approved these changes
Feb 22, 2024
enahum
approved these changes
Feb 22, 2024
enahum
added
the
4: Reviews Complete
|
@mvitale1989 - Are there developer or product documentation updates needed for this PR from your perspective? |
|
I went through the readme, the developer setup docs and the build docs and I don't see any mention of SDK versioning. This change was required to be able to push to the App store, and does not impact app building. In fact users are even free to use older SDKs and they would still work afaik. So I would say we don't really need to document this. cc @enahum please let me know if you have different thoughts on this |
|
No need to document this :) |
amyblais
added
Docs/Not Needed
cyrusjc
pushed a commit
to cyrusjc/mattermost-mobile
that referenced
this pull request
May 18, 2024
* CLD-7165 Bump MacOS runner version * Bump Ruby version * Adapt pipelines to utilize the ruby version in .ruby-version --------- Co-authored-by: Daniel Espino <larkox@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR bumps the MacOS runner version, in order to use a more recent iOS SDK.
The pipelines will also now utilize the
.ruby-versionfile, instead of specifying an explicit Ruby version to use themselves, to make future Ruby upgrades easier.Ticket Link
https://mattermost.atlassian.net/browse/CLD-7165
Device Information
This PR was tested on: TBD
Release Note