Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnt/restore doc sha #54

Merged
merged 3 commits into from Jan 6, 2023
Merged

Conversation

tacaswell
Copy link
Member

We used to include the exact commit used to build the docs in the footer (see https://matplotlib.org/3.4.3/index.html) however that got lost as part of the move to mpl-sphinx-theme. This adds the option to put this in the footer again.

The commit the docs are built from may be different from the commit of the
installed library.  This is always the case for our published documentation.
@QuLogic
Copy link
Member

QuLogic commented Dec 20, 2022

I guess lib_version would be set in downstream somewhere?

@tacaswell
Copy link
Member Author

matplotlib/matplotlib#24781 is what the downstream libraries would have to do.

@QuLogic QuLogic merged commit 5d2b419 into matplotlib:main Jan 6, 2023
@tacaswell tacaswell deleted the mnt/restore_doc_sha branch January 6, 2023 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants