New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: restore SHA to footer #24781
DOC: restore SHA to footer #24781
Conversation
This will also require a pin forward on the version of mpl-sphinx-theme we require to build the docs. |
There is no pin on |
ef7667d
to
5744893
Compare
5744893
to
cddb0f1
Compare
I am in favor of leaving the CSS tweaking for later. |
Feel free to self-merge if mpl-sphinx-theme is already at 3.7 |
it is in a funny state (due to branch protections I could not push the version bumping commit to main but I could push the tag, will fix that soon), but there is a release on pypi. |
manually cancelled the appevyor to unblock it for other PRs. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Will backport this as part of #25194 . |
DOC: restore SHA to footer (cherry picked from commit 73909bc)
DOC: restore SHA to footer (cherry picked from commit 73909bc)
DOC: restore SHA to footer (cherry picked from commit 73909bc)
DOC: restore SHA to footer (cherry picked from commit 73909bc)
Backport included in 3.7.0 final preparation |
PR Summary
Depends on matplotlib/mpl-sphinx-theme#54 being merged.
We used to include the exact commit used to build the docs in the footer (see https://matplotlib.org/3.4.3/index.html) however that got lost as part of the move to mpl-sphinx-theme. This adds the option to put this in the footer again.