Skip to content

Add limited, undocumented, Windows and macOS support #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

mcafaro
Copy link
Member

@mcafaro mcafaro commented Jan 5, 2022

This change adds limited, undocumented, Windows and macOS support for GitHub-hosted runners. Only the core MATLAB and Simulink products (no toolboxes) will be available for these platforms at this time.

Copy link
Member

@acampbel acampbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's move on this but continue to noodle on the e-matlab dropped file. The implicit-ness of this approach is a little off-putting. Maybe it is better in the end to pass the location into the install script after all, which clients would then need to (get to?) provide for themselves.

@mcafaro
Copy link
Member Author

mcafaro commented Jan 5, 2022

Looks good. Let's move on this but continue to noodle on the e-matlab dropped file. The implicit-ness of this approach is a little off-putting. Maybe it is better in the end to pass the location into the install script after all, which clients would then need to (get to?) provide for themselves.

An approach to consider in the future is to have a command (or subcommand of install) that resolves "latest" and then explictly pass the resolved release as well as an installation directory (formed from the resolved release name) to the install script. This pushes more logic out of the shared infrastructure but would remove the need for the drop file.

@mcafaro mcafaro merged commit 8091c47 into main Jan 5, 2022
@mcafaro mcafaro deleted the windows-and-macos branch January 5, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants