Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: dev: chg: avoid greedy allocation on graphql blocks call #958

Merged
merged 2 commits into from Aug 11, 2023

Conversation

marcello33
Copy link
Contributor

Description

Please, refer to ethereum/go-ethereum#27873

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Manual tests

Executed scripts as per bb22944 Immunify report

@marcello33 marcello33 changed the title dev: chg: avoid greedy allocation on graphql blocks call graphql: dev: chg: avoid greedy allocation on graphql blocks call Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.04% ⚠️

Comparison is base (d495949) 57.08% compared to head (a4b469d) 57.05%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #958      +/-   ##
===========================================
- Coverage    57.08%   57.05%   -0.04%     
===========================================
  Files          633      633              
  Lines        77324    77326       +2     
===========================================
- Hits         44141    44117      -24     
- Misses       29417    29445      +28     
+ Partials      3766     3764       -2     
Files Changed Coverage Δ
graphql/graphql.go 32.03% <0.00%> (-0.10%) ⬇️

... and 31 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 marked this pull request as ready for review August 11, 2023 12:13
@marcello33 marcello33 requested a review from a team August 11, 2023 12:14
@marcello33 marcello33 merged commit b4cc1f6 into develop Aug 11, 2023
6 of 8 checks passed
@marcello33 marcello33 deleted the mardizzone/bb22944 branch August 11, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants