Use less of plexus and no longer need to override plexus xml #894
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plexus is mostly deprecated, parts are over in maven shared that actually states deprecation and what to do. This one is simple move over now that we are on java 11. We still use plexus elsewhere otherwise.
we do not directly use this and plexus utils now properly defines version 3 for maven 3 usage instead of the maven 4 version that was showing up. Therefore, remove this as not needed to support here.
mathieucarbou
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plexus xml no longer needs to be in the pom. It was there because maven leaked maven 4 into the maven 3 code. They since fixed the issue.