Skip to content

fix: generate dist folder dynamically #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

wuda-io
Copy link
Member

@wuda-io wuda-io commented Nov 13, 2024

Proposed changes

Screenshots (if appropriate) or codepen:

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My commit messages follows the conventional commit format
  • My change requires a change to the documentation, and updated it accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Sorry, something went wrong.

@wuda-io wuda-io merged commit cd626d5 into v2-dev Nov 13, 2024
2 checks passed
@wuda-io wuda-io deleted the refactor-building-process branch November 13, 2024 14:37
@gselderslaghs
Copy link
Member

I don't think it's necessary to include sourcemaps on the compiled sass files in the dist folder as they point to local environment currently, it's better to keep them only for development of the framework

@gselderslaghs
Copy link
Member

Just did a quick test, we could exclude them by changing npm run build to npm run build -- --environment BUILD:release in npm scripts with addition of changing sourceMap: true to sourceMap: !(process.env.BUILD === 'release') in rollup config but I guess we'll need additional functionality for compress since generated sourcemaps are not deleted after a basic build, eg. in development fase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants