Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add darwin arm64 for typos #3559

Merged
merged 1 commit into from
Nov 26, 2023
Merged

add darwin arm64 for typos #3559

merged 1 commit into from
Nov 26, 2023

Conversation

chrisgrieser
Copy link
Contributor

@chrisgrieser chrisgrieser commented Nov 23, 2023

So typos does not have a dedicated built for arm64, but it does work fine on my arm64 machine.

So I suppose it wouldn't hurt to enable installing it via mason, even if it is not optimized? (Only added support for mac in this PR, since I do not have a linux/windows device and therefore cannot confirm that typos works there as well.)

@williambotman williambotman requested a review from a team November 23, 2023 22:46
Copy link
Member

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The target field allows an array of values, so I usually reduce it to:

    - target: [darwin_x64, darwin_arm64]
      file: typos-{{ version }}-x86_64-apple-darwin.tar.gz
      bin: typos

As for compatibility, most Intel (x64) binaries run fine on the Apple chips (arm64) because of Rosetta translation. There's overhead of course but for most use cases it's negligible.

@williamboman williamboman merged commit 31a839f into mason-org:main Nov 26, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants