Upgrade clap to 4.3.9 #1767
Merged
Upgrade clap to 4.3.9 #1767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we fail to parse the command line, even with `ignore_errors(true)` set, we currently let clap exit the process for us because we call `get_matches_from()`. We should instead propagate any errors and exit in `CliRunner::run()` as usual..
The new version has a change that makes `ignore_errors()` not ignore the error from `--help` (clap handles `--help` by returning an error). To compensate for that, I disabled the `--help` and `--version` flag and the `help` subcommand while parsing early arguments.
chooglen
approved these changes
Jun 28, 2023
It was clap-rs/clap#4988. I didn't read enough to understand it. |
|
I've read all the comments and still don't understand it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
If applicable:
CHANGELOG.md