-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Partially revert changes from #1081 #1242
Conversation
Sometimes, for unknown reasons, dotnet-outdated returns an error even if some of the NuGet packages are updated. Instead of failing, so all the NuGet packages updates are lost, instead just emit a warning and continue.
Regenerate the contents of the `dist` folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR partially reverts changes from #1081 to prevent the entire NuGet package update process from failing if dotnet-outdated returns an error, and it also corrects a spelling error.
- Corrected a typo in the error message for dotnet workload restore
- Changed the handling of dotnet outdated errors from failing (with exit) to emitting a warning instead
Comments suppressed due to low confidence (2)
.github/workflows/update-dotnet-sdk.yml:361
- The typo in 'workfload' has been corrected to 'workload'; please verify similar messages are updated accordingly for consistency.
Write-Output "::error::dotnet workload restore failed with code ${LASTEXITCODE}"
.github/workflows/update-dotnet-sdk.yml:392
- [nitpick] Changing the error output to a warning in the dotnet outdated step means the workflow will continue despite failures. Please confirm that this behavior is intentional and fully documented for future maintenance.
Write-Output "::warning::dotnet outdated failed with code ${LASTEXITCODE}"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 3 3
Lines 478 478
Branches 113 118 +5
=======================================
Hits 448 448
Misses 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update the action SHA to pick up changes from #1242.
Update the action SHA to pick up changes from #1242.
Instead of failing, so all the NuGet packages updates are lost, instead just emit a warning and continue.
dist
folder.