Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert changes from #1081 #1242

Merged
merged 3 commits into from
Mar 11, 2025
Merged

Partially revert changes from #1081 #1242

merged 3 commits into from
Mar 11, 2025

Conversation

martincostello
Copy link
Owner

  • Sometimes, for unknown reasons, dotnet-outdated returns an error even if some of the NuGet packages are updated.
    Instead of failing, so all the NuGet packages updates are lost, instead just emit a warning and continue.
  • Fix incorrect spelling of "workload".
  • Regenerate the contents of the dist folder.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sometimes, for unknown reasons, dotnet-outdated returns an error even if some of the NuGet packages are updated.
Instead of failing, so all the NuGet packages updates are lost, instead just emit a warning and continue.
Fix incorrect spelling of "workflow".
Regenerate the contents of the `dist` folder.
@martincostello martincostello added bug Something isn't working javascript Pull requests that update Javascript code labels Mar 11, 2025
@martincostello martincostello added this to the v3.4.2 milestone Mar 11, 2025
@Copilot Copilot bot review requested due to automatic review settings March 11, 2025 17:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR partially reverts changes from #1081 to prevent the entire NuGet package update process from failing if dotnet-outdated returns an error, and it also corrects a spelling error.

  • Corrected a typo in the error message for dotnet workload restore
  • Changed the handling of dotnet outdated errors from failing (with exit) to emitting a warning instead
Comments suppressed due to low confidence (2)

.github/workflows/update-dotnet-sdk.yml:361

  • The typo in 'workfload' has been corrected to 'workload'; please verify similar messages are updated accordingly for consistency.
Write-Output "::error::dotnet workload restore failed with code ${LASTEXITCODE}"

.github/workflows/update-dotnet-sdk.yml:392

  • [nitpick] Changing the error output to a warning in the dotnet outdated step means the workflow will continue despite failures. Please confirm that this behavior is intentional and fully documented for future maintenance.
Write-Output "::warning::dotnet outdated failed with code ${LASTEXITCODE}"

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.72%. Comparing base (c1d4f0f) to head (232bd0b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files           3        3           
  Lines         478      478           
  Branches      113      118    +5     
=======================================
  Hits          448      448           
  Misses         30       30           
Flag Coverage Δ
linux 93.72% <ø> (ø)
macos 93.72% <ø> (ø)
windows 93.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello enabled auto-merge (rebase) March 11, 2025 17:54
@martincostello martincostello merged commit 36ee289 into main Mar 11, 2025
11 checks passed
@martincostello martincostello deleted the revert-1081 branch March 11, 2025 17:57
martincostello added a commit that referenced this pull request Mar 11, 2025
Update the action SHA to pick up changes from #1242.
@martincostello martincostello mentioned this pull request Mar 11, 2025
martincostello added a commit that referenced this pull request Mar 11, 2025
Update the action SHA to pick up changes from #1242.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant