Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve deprecation flask sqlalchemy 3 #249

Conversation

woutervanoorschot
Copy link
Contributor

Fixes #247.

Also includes the changes from #248 as otherwise the changes cannot be committed.

Upgrade to black 22.3.0 to fix `ImportError: cannot import name '_unicodefun' from 'click'`

Pin dependency on importlib-metadata to 4.12.0 to resolve `AttributeError: 'EntryPoints' object has no attribute 'get'`
…m:woutervanoorschot/flask-marshmallow into pin-black-importlib-metadata-dependencies
Bump pyupgrade version to python 3.7
Remove azure python 3.6 pipeline
Require python >= 3.7 in setup
Add python 3.10 to tox
The flask sqlalchemy extension is stored directly in the extensions dictionary in version 3.0.0
Resolves deprecation of the .db attribute in Flask-SQLAlchemy 3.0.0
@woutervanoorschot woutervanoorschot force-pushed the 247-solve-deprecation-flask-sqlalchemy-3 branch from a8aafa7 to 0997e9d Compare November 9, 2022 16:31
@abettke
Copy link

abettke commented Jan 12, 2023

Bumping for interest

Copy link
Collaborator

@sirosen sirosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work!

I'm ramping up as a new maintainer of flask-marshmallow, so it will take a little bit more time before this can be released as I get up to speed. However, this is a huge help in terms of getting the project back into ship-shape!

I had one question on one of the changes, but everything else here looks good to me, so I'm going to merge in order to get dev back into a working state.

.pre-commit-config.yaml Show resolved Hide resolved
@sirosen sirosen merged commit fcd91d1 into marshmallow-code:dev Feb 6, 2023
@jgriffon jgriffon mentioned this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning from Flask-SQLAlchemy for app.extensions["sqlalchemy"]
3 participants