Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix some videos do not play in Firefox for MacOS users #10524

Merged
merged 14 commits into from
Feb 21, 2025

Conversation

erwanMarmelab
Copy link
Contributor

@erwanMarmelab erwanMarmelab commented Feb 17, 2025

MacOS Firefox error:

image

image

Bad files:

all .gif files

./docs/img/FilterLiveForm.mp4

./docs/img/autocomplete-input-with-create.mp4

./docs/img/autocomplete-input-with-create.webm

./docs/img/prev-next-buttons-edit.mp4

./docs/img/prev-next-buttons-edit.webm

./docs/img/prev-next-buttons-show.mp4

./docs/img/prev-next-buttons-show.webm

./docs/img/prev-next-buttons.mp4

./docs/img/prev-next-buttons.webm

./docs/img/translatable-fields-basic.mp4

./docs/img/translatable-fields-basic.webm

./docs/img/translatable-fields-with-custom-selector.mp4

./docs/img/translatable-fields-with-custom-selector.webm

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…a bad encoding
@erwanMarmelab erwanMarmelab added the RFR Ready For Review label Feb 17, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Partially verified

This commit is signed with the committer’s verified signature.
penalosa’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@fzaninotto
Copy link
Member

In my tests, only the FilterLiveForm video was broken on Firefox Mac before your PR. Do we really need to update the others?

@slax57 slax57 self-requested a review February 21, 2025 13:14
@slax57 slax57 merged commit e547f7f into master Feb 21, 2025
2 checks passed
@slax57 slax57 deleted the CI/check_videod_chromasubsampling branch February 21, 2025 13:37
@slax57 slax57 added this to the 5.6.1 milestone Feb 21, 2025
@slax57 slax57 changed the title Check videos "Chroma Subsampling" on CI check and explain how to fix a bad encoding [Doc] Fix some videos do not play in Firefox for MacOS users Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants