Add check in splitCells to prevent calling trim on undefined #2372
+28
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked version: 4.0.11
Markdown flavor: GitHub Flavored Markdown
Description
Fixes #2371
Expectation
With this change I expect the example given in the issue to not cause a JavaScript error.
Result
The test case no longer throws an error and instead renders the table properly.
What was attempted
This PR adds a simple check to the
splitCells
helper function that validates that thecells
array isn't empty before callingcells[cells.length - 1].trim()
. This prevents the error "Cannot read properties of undefined (reading 'trim')" from being thrown.Contributor
Committer
In most cases, this should be a different person than the contributor.