Re-export Node in a way that allows runtime use #540
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously it wasn't possible to have code like
import { Node } from '@markdoc/markdoc'
function f(): Node {
// error below: 'Node' cannot be used as a value because it was exported using 'export type'.ts(1362)
return new Node('tag', {}, [], 'foo')
}
This patch rectifies that and we can have the same type used in return
type position and the class instantiation position.
Resolves: markdoc#539
jstasiak
commented
Jan 20, 2025
| @@ -113,6 +114,7 @@ export { | |||
| transforms, | |||
| renderers, | |||
| Ast, | |||
| Node, | |||
There was a problem hiding this comment.
I was afraid
export * from './src/types';
was going to clash with this (re)export but after some preliminary tests I think it's fine.
segphault
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't possible to have code like
This patch rectifies that and we can have the same type used in return type position and the class instantiation position.
Resolves: #539