fix: default to opt-in for introspection of tables #3940
Merged
+91
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Light2Dark
changed the title
mscolnick
reviewed
Feb 28, 2025
mscolnick
reviewed
Feb 28, 2025
docs/guides/working_with_data/sql.md
Outdated
| @@ -187,6 +187,17 @@ marimo will automatically discover the database connection and display the datab | |||
| </figure> | |||
| </div> | |||
|
|
|||
| !!! note | |||
|
|
|||
| marimo currently supports auto-discovery up to the schema level. If you want to discover tables and columns, you can enable it in your `.marimo.toml` file. Note that auto-discovery can be slow for large databases. | |||
There was a problem hiding this comment.
since it might be on a notebook-by-notebook basic, maybe we suggest pyproject.toml since we not support that?
and would be:
```toml title="pyrpoject.toml"
[tool.marimo.datasources]
There was a problem hiding this comment.
thanks for the suggestions, sry I missed this.
Light2Dark
commented
Feb 28, 2025
mscolnick
reviewed
Feb 28, 2025
akshayka
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Not sure what you think about this, but this may be a temporary solution for the issue here: https://discord.com/channels/1059888774789730424/1338959377411084390/1344967482577915905.
By default, we do not introspect tables, we let users opt-in by changing config.
🔍 Description of Changes
For future MRs:
remove introspection for meta schemas, make this a config.(if we load on-demand, we do not need to do this)information_schemadoes not need to be introspected I think..📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick