Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: removed border and and fix tooltips when multi-column view #3649

Merged

Conversation

Light2Dark
Copy link
Collaborator

📝 Summary

Let me know what you think!

Before border:
image

After border:
image

Before Tooltips After Tooltips
Before After

🔍 Description of Changes

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero
Copy link

vercel bot commented Feb 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
marimo-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 1, 2025 7:01pm

Copy link

vercel bot commented Feb 1, 2025

@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

@akshayka
Copy link
Contributor

akshayka commented Feb 1, 2025

This looks great! I vaguely remember we had issues with portaling tooltips a long time ago but I could be wrong (@mscolnick)

mscolnick
mscolnick previously approved these changes Feb 1, 2025
@mscolnick
Copy link
Contributor

Yea I think portalling caused some reflows and perf issues. With react compiler and upgrading the components, it might be better now. I can do some investigating

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero

Verified

This commit was signed with the committer’s verified signature.
abelsromero Abel Salgado Romero
@mscolnick mscolnick force-pushed the multicol-small-ui-improvement branch from b195b32 to 90d4ead Compare February 1, 2025 19:10
@mscolnick mscolnick merged commit 88c660a into marimo-team:main Feb 1, 2025
17 of 20 checks passed
Copy link

github-actions bot commented Feb 1, 2025

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.20-dev13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants