fix: transforms on dataframe to be reactive #3566
Merged
+4
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fixes #3090 . Previously, the
isEqual
check will always return true.onInvalidChange -> sets
internalValue
tonewValue
from the formonChange -> checks whether
newValue
andinternalValue
are the same. Yes, they would be.Screen.Recording.2025-01-25.at.12.01.02.AM.mov
There's some flickering going on (not new issue) when toggling from no cols to 1 col, hard to figure out..
📋 Checklist
📜 Reviewers
@akshayka OR @mscolnick