Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: transforms on dataframe to be reactive #3566

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

Light2Dark
Copy link
Collaborator

@Light2Dark Light2Dark commented Jan 24, 2025

📝 Summary

Fixes #3090 . Previously, the isEqual check will always return true.
onInvalidChange -> sets internalValue to newValue from the form
onChange -> checks whether newValue and internalValue are the same. Yes, they would be.

Screen.Recording.2025-01-25.at.12.01.02.AM.mov

There's some flickering going on (not new issue) when toggling from no cols to 1 col, hard to figure out..

📋 Checklist

  • I have read the contributor guidelines.
  • For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@akshayka OR @mscolnick

Sorry, something went wrong.

Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:16pm

Copy link

vercel bot commented Jan 24, 2025

@Light2Dark is attempting to deploy a commit to the marimo Team on Vercel.

A member of the Team first needs to authorize it.

@Light2Dark Light2Dark changed the title compare newValues from the form against existing state fix: transforms on dataframe to be reactive Jan 24, 2025
@mscolnick mscolnick merged commit 34d33c6 into marimo-team:main Jan 24, 2025
19 of 20 checks passed
Copy link

🚀 Development release published. You may be able to view the changes at https://marimo.app?v=0.10.17-dev13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataframe selecting columns does not apply until adding another transformation
2 participants